Conversation
googlebot
added
the
cla: yes
mandarjog
requested review from
kyessenov and
qiwzhang
and removed request for
qiwzhang
kyessenov
left a comment
kyessenov
left a comment
There was a problem hiding this comment.
Could you please add inbound and outbound words?
And run code generation script please...
|
Do I need to run generation scripts when updating |
mandarjog
force-pushed
the
proxy_error_code
branch
from
a003188 to
96ce3d9
Compare
kyessenov
left a comment
kyessenov
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Right, there seems to be no generated file for the dictionary.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyessenov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - DI | ||
| - FI | ||
| - RL | ||
| - "-" |
There was a problem hiding this comment.
@mandarjog
Line 316 - "-" break the proxy build as create_global_dictionary.py parse it to: ""-"", which is invalid in .cc.
Could you suggest the proper way to fix this? Should we just remove the " or make it \"-\" or even update the script?
5 participants
Proxy returns error codes generated by itself to Mixer.